-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moves from vuex to pinia #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for obe-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for obe-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Deploying open-block-explorer with Cloudflare Pages
|
pmjanus
previously approved these changes
May 9, 2024
Viterbo
approved these changes
May 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Job !!
I just deleted a couple of commented code lines (on the test files)
This was referenced May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #537
Description
This PR replaces vuex with pinia.
Other relevant changes:
declare module '@vue/runtime-core'
to the newdeclara module 'vue'
, since runtime-core is now included and its usage is not recommended on applications, as mentioned hereaxios
from globals to avoid tight couplingshallowMount()
to amount()
specifying a stub for the child component due to an error caused specifically by theshallowMount()
usage that has been around sincevue v3.2.32
. See screenshot of the errorUse node 20+ to build
Test scenarios
Checklist: