Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves from vuex to pinia #845

Merged
merged 9 commits into from
May 15, 2024
Merged

Moves from vuex to pinia #845

merged 9 commits into from
May 15, 2024

Conversation

karynemayer
Copy link
Contributor

@karynemayer karynemayer commented Apr 17, 2024

Fixes #537

Description

This PR replaces vuex with pinia.

  • All stores have been updated
  • All store usage has been updated
  • All unit tests have been updated

Other relevant changes:

  • Changes declare module '@vue/runtime-core' to the new declara module 'vue', since runtime-core is now included and its usage is not recommended on applications, as mentioned here
  • Removed axios from globals to avoid tight coupling
  • I replaced the use of shallowMount() to a mount() specifying a stub for the child component due to an error caused specifically by the shallowMount() usage that has been around since vue v3.2.32. See screenshot of the error
Screenshot 2024-04-16 at 18 40 49
Use node 20+ to build

Test scenarios

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage
  • I have updated relevant documentation and/or opened a separate issue to cover the updates (Issue URL: )

Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for obe-testnet ready!

Name Link
🔨 Latest commit a545ffa
🔍 Latest deploy log https://app.netlify.com/sites/obe-testnet/deploys/663ea0f972e0a7000824470b
😎 Deploy Preview https://deploy-preview-845--obe-testnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for obe-staging ready!

Name Link
🔨 Latest commit a545ffa
🔍 Latest deploy log https://app.netlify.com/sites/obe-staging/deploys/663ea0f80ca1780008eb0453
😎 Deploy Preview https://deploy-preview-845--obe-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cloudflare-workers-and-pages bot commented Apr 23, 2024

Deploying open-block-explorer with  Cloudflare Pages  Cloudflare Pages

Latest commit: a545ffa
Status: ✅  Deploy successful!
Preview URL: https://c90b7c0e.open-block-explorer.pages.dev
Branch Preview URL: https://pinia.open-block-explorer.pages.dev

View logs

pmjanus
pmjanus previously approved these changes May 9, 2024
Copy link
Collaborator

@Viterbo Viterbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job !!
I just deleted a couple of commented code lines (on the test files)

@karynemayer karynemayer requested a review from pmjanus May 13, 2024 21:43
@pmjanus pmjanus merged commit 1dc724a into develop May 15, 2024
10 checks passed
@pmjanus pmjanus deleted the pinia branch May 15, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants